Skip to content

src: add initial shadow realm support#42869

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
legendecas:shadow-realm/constructor
May 2, 2022
Merged

src: add initial shadow realm support#42869
aduh95 merged 1 commit into
nodejs:masterfrom
legendecas:shadow-realm/constructor

Conversation

@legendecas

@legendecas legendecas commented Apr 25, 2022

Copy link
Copy Markdown
Member

Add initial shadow realm support behind an off-by-default flag--experimental-shadow-realm.

This enables the ShadowRealm constructor and ShadowRealm.prototype.evaluate support in Node.js.

Refs: #42528

@nodejs-github-bot

nodejs-github-bot commented Apr 25, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 25, 2022
@legendecas legendecas force-pushed the shadow-realm/constructor branch from 30dc744 to 8004257 Compare April 25, 2022 16:43
@legendecas legendecas marked this pull request as ready for review April 25, 2022 16:44
@legendecas legendecas force-pushed the shadow-realm/constructor branch from 8004257 to 4990c42 Compare April 25, 2022 16:51
aduh95
aduh95 reviewed Apr 26, 2022
View reviewed changes
Comment thread doc/api/cli.md
@aduh95

aduh95 commented Apr 26, 2022

Copy link
Copy Markdown
Contributor

Can you add an entry to lib/.eslintrc.yml in the same vein as SharedArrayBuffer

node/lib/.eslintrc.yaml

Lines 90 to 93 in 560cbc5

# SharedArrayBuffer is not available in primordials because it can be
# disabled with --no-harmony-sharedarraybuffer CLI flag.
- name: SharedArrayBuffer
message: Use `const { SharedArrayBuffer } = globalThis;` instead of the global.

targos
targos reviewed Apr 26, 2022
View reviewed changes
Comment thread test/parallel/test-shadow-realm.js Outdated
@legendecas legendecas force-pushed the shadow-realm/constructor branch from 4990c42 to ad41c28 Compare April 26, 2022 15:46
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. semver-minor PRs that contain new features and should be released in the next minor version. dont-land-on-v12.x labels Apr 26, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2022
@nodejs-github-bot

nodejs-github-bot commented Apr 26, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43711/

@github-actions github-actions Bot mentioned this pull request Apr 27, 2022
Open
11 tasks
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2022
@nodejs-github-bot

nodejs-github-bot commented Apr 27, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43720/

RaisinTen
RaisinTen reviewed Apr 27, 2022
View reviewed changes
Comment thread doc/api/cli.md Outdated
Comment thread node.gyp
@legendecas legendecas force-pushed the shadow-realm/constructor branch from ad41c28 to c1f9e4c Compare April 27, 2022 14:58
@github-actions github-actions Bot mentioned this pull request Apr 28, 2022
Open
18 tasks
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 28, 2022
@JakobJingleheimer JakobJingleheimer mentioned this pull request May 4, 2022
Closed
@github-actions github-actions Bot mentioned this pull request May 5, 2022
Open
32 tasks
@sepehrst

sepehrst commented May 28, 2022

Copy link
Copy Markdown

The CLI option --experimental-shadow-realm is not reflected in node --help output. Is that intentional?

@danielleadams danielleadams mentioned this pull request Jun 11, 2022
Merged
@ruyadorno

ruyadorno commented Aug 23, 2022

Copy link
Copy Markdown
Member

@aduh95 is it intentional to have marked this PR as backport-blocked-v18.x ?

@RafaelGSS RafaelGSS mentioned this pull request Sep 13, 2022
Merged
@joyeecheung

joyeecheung commented Oct 14, 2022

Copy link
Copy Markdown
Member

Ping @Adu95 is there a reason that this should be marked backport-blocked-v18.x? Would be better if we backport this to avoid conflicts with other Realm refactoring PRs.

@aduh95

aduh95 commented Oct 14, 2022

Copy link
Copy Markdown
Contributor

Sorry I missed the original ping, IIRC it was due to an incompatible version of V8 on v18.x, maybe it's ready to be backported now, it's worth trying.

@joyeecheung joyeecheung mentioned this pull request Oct 14, 2022
Closed
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos left review comments

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

+1 more reviewer

@amusaber950 amusaber950 amusaber950 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@legendecas @nodejs-github-bot @aduh95 @RaisinTen @sepehrst @ruyadorno @joyeecheung @targos @amusaber950